RFR: 8313530: VM build without C2 fails after JDK-8312579 [v2]

[Hao Sun]

On Wed, 23 Aug 2023 08:24:08 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

>> The EnableVectorSupport flag is declared in `opto/c2_globals.hpp`, which is not included if `COMPILER2` is not set. But after my changes for [JDK-8312579](https://bugs.openjdk.org/browse/JDK-8312579) we try to access this flag in some places guarded by `#if COMPILER2_OR_JVMCI`.
>> 
>> This PR moves some flags from `c2_globals.hpp` to the shared `compiler_globals.hpp`, so that they are accessible even if C2 is disabled but JVMCI is enabled.
>
> Gergö Barany has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add copies of Vector API flags in jvmci_globals.hpp
>  - Revert "8313530: VM build without C2 fails after JDK-8312579"
>    
>    This reverts commit d82e89c469e91f78f9c2e5b28c725b0e1ba0fb8c.

Verified with Linux/AArch64 and Linux/x86_64 that VM build without C2 is passed now.

Marked as reviewed by haosun (Committer).

src/hotspot/share/jvmci/jvmci_globals.hpp line 185:

> 183:                                                                             \
> 184:   NOT_COMPILER2(product(bool, UseVectorStubs, false, EXPERIMENTAL,          \
> 185:           "Use stubs for vector transcendental operations"))                \

nit: remove the backslash?
Suggestion:

          "Use stubs for vector transcendental operations"))

-------------

Marked as reviewed by haosun (Committer).

PR Review: https://git.openjdk.org/jdk/pull/15384#pullrequestreview-1590961843
PR Review: https://git.openjdk.org/jdk/pull/15384#pullrequestreview-1590987883
PR Review Comment: https://git.openjdk.org/jdk/pull/15384#discussion_r1302617993