RFR: 8313530: VM build without C2 fails after JDK-8312579 [v2]

[Gergö Barany]

On Wed, 23 Aug 2023 07:45:52 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Gergö Barany has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add copies of Vector API flags in jvmci_globals.hpp
>>  - Revert "8313530: VM build without C2 fails after JDK-8312579"
>>    
>>    This reverts commit d82e89c469e91f78f9c2e5b28c725b0e1ba0fb8c.
>
> src/hotspot/share/jvmci/jvmci_globals.hpp line 185:
> 
>> 183:                                                                             \
>> 184:   NOT_COMPILER2(product(bool, UseVectorStubs, false, EXPERIMENTAL,          \
>> 185:           "Use stubs for vector transcendental operations"))                \
> 
> nit: remove the backslash?
> Suggestion:
> 
>           "Use stubs for vector transcendental operations"))

I added the backslash for consistency with C2: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/c2_globals.hpp#L776-L778. It also makes future changes nicer, since appending more flags will not need to touch unrelated lines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15384#discussion_r1302631905