RFR: 8313530: VM build without C2 fails after JDK-8312579 [v2]

Hao Sun haosun at openjdk.org
Wed Aug 23 09:12:42 UTC 2023


On Wed, 23 Aug 2023 07:57:09 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

>> src/hotspot/share/jvmci/jvmci_globals.hpp line 185:
>> 
>>> 183:                                                                             \
>>> 184:   NOT_COMPILER2(product(bool, UseVectorStubs, false, EXPERIMENTAL,          \
>>> 185:           "Use stubs for vector transcendental operations"))                \
>> 
>> nit: remove the backslash?
>> Suggestion:
>> 
>>           "Use stubs for vector transcendental operations"))
>
> I added the backslash for consistency with C2: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/c2_globals.hpp#L776-L778. It also makes future changes nicer, since appending more flags will not need to touch unrelated lines.

Yes. Agree. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15384#discussion_r1302634925


More information about the hotspot-compiler-dev mailing list