RFR: 8309463: IGV: Dynamic graph layout algorithm [v7]

[emmyyin]

On Tue, 22 Aug 2023 11:04:39 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> emmyyin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixing trailing ws
>
> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/HierarchicalStableLayoutManager.java line 189:
> 
>> 187:                     assert e.to.layer == n.layer + 1;
>> 188:                 } else {
>> 189:                     n.succs.remove(e);
> 
> This removal and the one in the next loop seem unexpected being in a sanity check method where the expectation would be to only query and not modify. Do we really need these removals for the correctness of the algorithm?

Yes, it breaks often if removed. It's mostly sanity checking but also ensuring the state of the graph is correct by fixing weird edge connections

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1305387010