RFR: 8309463: IGV: Dynamic graph layout algorithm [v7]

[Christian Hagedorn]

On Fri, 25 Aug 2023 08:46:39 GMT, emmyyin <duke at openjdk.org> wrote:

>> Okay, thanks for the explanation. The code in `HierarchicalLayoutManager` looks very similar. So, you could also change `relativeTo` and `relativeFrom` to zero there. Or even better share the code somehow (if I see that correctly, the only difference is how to insert the node - `nodes.add(n)` vs. `insertNode(n, layer)`).
>
> @robcasloz has created a suggestion list of how to improve `HierarchicalLayoutManager`. Could we perhaps add this to that list instead? I think there must have been some reason to set `n.width/2` (maybe just in case you want to make the dummy nodes visible with a larger width) so it could be worth to work it through some more

I'm fine with moving this and my other suggested clean-ups to this list. However, even after removing `sanityCheckNodesAndLayerNodes()` and additionally removing the `assert` checks (which are currently still in the code), the example graph mentioned earlier still needs around 18s to load on my machine. The bottleneck is now `sanityCheckEdges()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1305451093