RFR: 8309463: IGV: Dynamic graph layout algorithm [v7]

emmyyin duke at openjdk.org
Mon Aug 28 07:24:20 UTC 2023


On Fri, 25 Aug 2023 09:52:03 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Yes, it breaks often if removed. It's mostly sanity checking but also ensuring the state of the graph is correct by fixing weird edge connections
>
> As mentioned below, this method is still a bottleneck and we spend quite some time inside it. Overall, it attributes to around 90% of the overall time to open the graph in the example mentioned earlier. Is there another way to fix these breakages instead of looping over all nodes and edges here?

I am not sure, I've tried to find other solutions but have not managed. The function can be called less, but not removed entirely. A suggestion is to put it up as a future enhancement?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1307011222


More information about the hotspot-compiler-dev mailing list