RFR: 8309463: IGV: Dynamic graph layout algorithm [v7]

[emmyyin]

On Tue, 22 Aug 2023 11:57:16 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> emmyyin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixing trailing ws
>
> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/HierarchicalStableLayoutManager.java line 1450:
> 
>> 1448:         }
>> 1449: 
>> 1450:         public void insert(LayoutNode n, int pos) {
> 
> This method and also other code is duplicated from `HierarchicalLayoutManager`. Could the code be shared somehow?

I have made the shared parts public in `HierarchicalLayoutManager` and reused in `HierarchicalStableLayoutManager`. Is this the way to go or should we move them out to a  `LayoutManagerUtils` class instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1307031812