RFR: 8309463: IGV: Dynamic graph layout algorithm [v7]

[Roberto Castañeda Lozano]

On Mon, 28 Aug 2023 07:42:09 GMT, emmyyin <duke at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/HierarchicalStableLayoutManager.java line 1450:
>> 
>>> 1448:         }
>>> 1449: 
>>> 1450:         public void insert(LayoutNode n, int pos) {
>> 
>> This method and also other code is duplicated from `HierarchicalLayoutManager`. Could the code be shared somehow?
>
> I have made the shared parts public in `HierarchicalLayoutManager` and reused in `HierarchicalStableLayoutManager`. Is this the way to go or should we move them out to a  `LayoutManagerUtils` class instead?

Reusing directly from `HierarchicalLayoutManager` looks good to me, since `HierarchicalStableLayoutManager` already depends on it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1307168854