RFR: 8312332: C2: Refactor SWPointer out from SuperWord [v3]

[Pengfei Li]

On Thu, 10 Aug 2023 12:06:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move the cache of _pre_loop_end to CountedLoopNode
>
> src/hotspot/share/opto/vectorization.cpp line 50:
> 
>> 48:   _nstack(nstack), _analyze_only(analyze_only), _stack_idx(0)
>> 49: #ifndef PRODUCT
>> 50:   , _tracer((phase->C->directive()->VectorizeDebugOption & 2) > 0)
> 
> You should also refactor the accessors for `VectorizeDebugOption`. I would move it from SuperWord to `vectorization.hpp/cpp` somehow. We should only do the "masking" `& 2` in one single place.

Right, but doing this requires moving more handles including `phase` to `vectorization.hpp/cpp`. Perhaps we need to create a new class there first. I have created another task (https://bugs.openjdk.org/browse/JDK-8315361) and would like to do more refactoring later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15013#discussion_r1310141583