RFR: 8312332: C2: Refactor SWPointer out from SuperWord [v3]

[Pengfei Li]

On Thu, 10 Aug 2023 12:17:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move the cache of _pre_loop_end to CountedLoopNode
>
> src/hotspot/share/opto/vectorization.cpp line 40:
> 
>> 38: #endif
>> 39: 
>> 40: VPointer::VPointer(MemNode* mem, PhaseIdealLoop* phase, IdealLoopTree* lpt,
> 
> You could also call it `LPointer` or `LoopPointer`. `VPointer` sounds like `VectorPointer` - but it is not a pointer of a vector but a scalar memop. That could be confusing. But you could also argue it is a `VectorizationPointer`, and hence `VPointer.`

My idea is keeping the name as short as possible. I think it should be `VectorizationPointer` so `VPointer`. In my opinion, `LoopPointer` also sounds like a pointer to a loop but it isn't. I'd like to have more suggestions from other reviewers about the name.

BTW: `VPointer` is also used for vector memop in `SuperWord::output()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15013#discussion_r1310151670