RFR: 8295166: IGV: dump graph at more locations

[Daniel Lundén]

On Thu, 2 Nov 2023 16:46:36 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Not quite, there is one unguarded call for `PHASE_PHASEIDEALLOOP_ITERATIONS` at level 2. This is an existing phase that I converted from `print_method` to `print_method_iter` (as suggested by @chhagedorn in the issue corresponding to this PR).
>
> The current rule seems to be that we always want to emit a JFR event when dumping a graph - regardless of whether we dump a graph or not. I think we should follow this convention and remove the `NOT_PRODUCT` from the calls to `print_method_iter()`.
> 
> On a separate note, I'm wondering how useful it is to always dump all events when calling `print_method()`. Should this be revisited again in general?

I have now incorporated the functionality of `print_method_iter` directly into `print_method`, and also removed all the `NOT_PRODUCT` wrappers.

I'm resolving this thread now, should we move the discussion regarding JFR event dumping somewhere else?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1383053251