RFR: 8295166: IGV: dump graph at more locations

Christian Hagedorn chagedorn at openjdk.org
Tue Dec 5 12:13:18 UTC 2023


On Mon, 6 Nov 2023 10:06:52 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> The current rule seems to be that we always want to emit a JFR event when dumping a graph - regardless of whether we dump a graph or not. I think we should follow this convention and remove the `NOT_PRODUCT` from the calls to `print_method_iter()`.
>> 
>> On a separate note, I'm wondering how useful it is to always dump all events when calling `print_method()`. Should this be revisited again in general?
>
> I have now incorporated the functionality of `print_method_iter` directly into `print_method`, and also removed all the `NOT_PRODUCT` wrappers.
> 
> I'm resolving this thread now, should we move the discussion regarding JFR event dumping somewhere else?

Maybe we can mention it as a side node in the PR description that it is something we should think about at some point. But it should not block this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1383078760


More information about the hotspot-compiler-dev mailing list