RFR: 8295166: IGV: dump graph at more locations

[Daniel Lundén]

On Fri, 3 Nov 2023 15:44:52 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/phasetype.hpp line 31:
>> 
>>> 29:   flags(BEFORE_STRINGOPTS,              "Before StringOpts") \
>>> 30:   flags(AFTER_STRINGOPTS,               "After StringOpts") \
>>> 31:   flags(BEFORE_REMOVEUSELESS,           "Before RemoveUseless") \
>> 
>> General comments here. I would add a `AFTER_` to match the `BEFORE_` phases for consistency where you also mention "After" in the name string.
>
> I believe I've kept it consistent for my own additions, but the older phase names are sometimes inconsistent in this regard (including `STRINGOPTS`). Should I rename other phases to improve consistency? This changeset will touch many more files then, but perhaps that's OK.

My mistake, it was actually called `BEFORE_STRINGOPTS` and `AFTER_STRINGOPTS`. But, the old phases `MATCHING` and `MACH_ANALYSIS` do contain "After" in the string but not in the name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1381912649