RFR: 8295166: IGV: dump graph at more locations

Daniel Lundén duke at openjdk.org
Tue Dec 5 12:13:21 UTC 2023


On Fri, 3 Nov 2023 15:52:59 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> I believe I've kept it consistent for my own additions, but the older phase names are sometimes inconsistent in this regard (including `STRINGOPTS`). Should I rename other phases to improve consistency? This changeset will touch many more files then, but perhaps that's OK.
>
> My mistake, it was actually called `BEFORE_STRINGOPTS` and `AFTER_STRINGOPTS`. But, the old phases `MATCHING` and `MACH_ANALYSIS` do contain "After" in the string but not in the name.

I'll resolve this by using `BEFORE_` and `AFTER_` for all new phases that I'm adding, but leaving existing phase names intact. We can address inconsistencies in another RFE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1383062476


More information about the hotspot-compiler-dev mailing list