RFR: 8321001: RISC-V: C2 SignumVF [v3]

Fei Yang fyang at openjdk.org
Wed Dec 6 02:46:37 UTC 2023


On Tue, 5 Dec 2023 13:58:09 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/assembler_riscv.hpp line 1592:
>> 
>>> 1590:   INSN(vfsgnj_vf, 0b1010111, 0b101, 0b001000);
>>> 1591:   INSN(vfsgnjx_vf, 0b1010111, 0b101, 0b001010);
>>> 1592:   INSN(vfsgnjn_vf, 0b1010111, 0b101, 0b001001);
>> 
>> Not used anywhere?
>
> I can remove them if you think it's better to do it.
> Reason I added them is that they're quite similar instructions and it's annoying to lookup the instruction formatting in spec and add every single one when needing them.

Ah, I would suggest remove them for test coverity reasons. We can add them back when needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16925#discussion_r1416581988


More information about the hotspot-compiler-dev mailing list