RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v21]

[Emanuel Peter]

On Mon, 4 Dec 2023 13:47:43 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggestions by Christian for naming
>
> src/hotspot/share/opto/superword.cpp line 1750:
> 
>> 1748:   } else {
>> 1749:     C_init = scale;
>> 1750:   }
> 
> I suggest to make it implicit to better follow the logic:
> Suggestion:
> 
>   if (init_node->is_ConI()) {
>     C_const_init = init_node->as_ConI()->get_int();
>     C_init = 0;
>   } else {
>     C_const_init = 0
>     C_init = scale;
>   }

I should also add some more comments here

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1417472901