RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v21]

Christian Hagedorn chagedorn at openjdk.org
Thu Dec 7 07:06:50 UTC 2023


On Wed, 6 Dec 2023 16:42:24 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> `var_invar` is slightly confusing. Maybe we should flip it to `invar_var` to be consistent with `invar_factor`? Or maybe you find another name for that term. I could not come up with something better for now.
>
> I really don't know anything better than `var_invar`. The idea is that there is both a constant `C` and variable `var` term for both the `init` and `invar` terms. I even explain that below, that there is a such a factorization into constant and variable.

I agree with you - I also cannot think of something better. Let's keep it like that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1418476576


More information about the hotspot-compiler-dev mailing list