RFR: 8317721: RISC-V: Implement CRC32 intrinsic

[Feilong Jiang]

On Mon, 11 Dec 2023 01:59:33 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:

> Hi everyone! Please review this port of [AArch64](https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp#L4224) `_updateBytesCRC32`, `_updateByteBufferCRC32` and `_updateCRC32` intrinsics. This patch introduces only the plain (non-vectorized, no Zbc) version.
> 
> ### Correctness checks
> 
> Tier 1/2 tests are ok.
> 
> ### Performance results on T-Head board
> 
> #### Results for enabled intrinsic:
> 
> Used test is `test/micro/org/openjdk/bench/java/util/TestCRC32.java`
> 
> | Benchmark                                             |  (count) |  Mode | Cnt    | Score |   Error |  Units |
> | --- | ---- | ----- | --- | ---- | --- | ---- |
> | CRC32.TestCRC32.testCRC32Update  |     64  | thrpt     | 24 | 3730.929 | 37.773 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |    128 |  thrpt    | 24 | 2126.673 |  2.032 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |    256 | thrpt    |  24 | 1134.330 |  6.714 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |    512 | thrpt    |  24 |  584.017 |  2.267 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |   2048 |  thrpt   |   24 |  151.173 |  0.346 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |   16384 | thrpt |  24 |   19.113 |  0.008 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update  |  65536 | thrpt  | 24  |   4.647 | 0.022 | ops/ms |
> 
> #### Results for disabled intrinsic:
> 
> | Benchmark                                            | (count)  |  Mode | Cnt |   Score  |  Error   | Units     |
> | --------------------------------------------------- | ---------- | --------- | ---- | ----------- | --------- | ---------- | 
> | CRC32.TestCRC32.testCRC32Update |      64    |  thrpt   | 15  | 798.365 | 35.486 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |     128   |  thrpt   | 15  | 677.756 | 46.619 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |     256   |  thrpt   | 15  | 552.781 | 27.143 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |     512   |  thrpt   | 15  | 429.304 | 12.518 | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |    2048  |  thrpt   | 15  | 166.738 |  0.935  | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |   16384 |  thrpt   | 15  |  25.060  | 0.034   | ops/ms |
> | CRC32.TestCRC32.testCRC32Update |   65536 |  thrpt   | 15  |   6.196   | 0.030   | ops/ms |

Changes requested by fjiang (Committer).

src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1642:

> 1640:   __ xori(crc, crc, -1); // ~crc
> 1641:   __ slli(crc, crc, 32);
> 1642:   __ srli(crc, crc, 32);

Suggestion:

  __ notr(crc, crc); // ~crc
  __ zero_extend(crc, crc, 32);

src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1646:

> 1644:   __ xori(res, crc, -1); // ~crc
> 1645:   __ slli(crc, crc, 32);
> 1646:   __ srli(crc, crc, 32);

Suggestion:

  __ notr(res, crc); // ~crc
  __ zero_extend(crc, crc, 32);

-------------

PR Review: https://git.openjdk.org/jdk/pull/17046#pullrequestreview-1778668061
PR Review Comment: https://git.openjdk.org/jdk/pull/17046#discussion_r1424730144
PR Review Comment: https://git.openjdk.org/jdk/pull/17046#discussion_r1424729897