RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v43]

Emanuel Peter epeter at openjdk.org
Fri Dec 15 12:12:57 UTC 2023


On Fri, 15 Dec 2023 08:10:47 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamings and proof improvement in adjust_pre_loop_limit_to_align_main_loop_vectors
>
> src/hotspot/share/opto/superword.cpp line 3495:
> 
>> 3493:   // alignment of the address.
>> 3494:   //
>> 3495:   //   adr = base + offset + invar + scale * iv                               (1)
> 
> For completeness, you can also add the desired `% aw = 0`:
> Suggestion:
> 
>   //   adr = (base + offset + invar + scale * iv) % aw = 0                    (1)

I moved `adr % aw = 0` up, flipping (2) and (3)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1427906257


More information about the hotspot-compiler-dev mailing list