RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v43]

[Emanuel Peter]

On Fri, 15 Dec 2023 10:46:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamings and proof improvement in adjust_pre_loop_limit_to_align_main_loop_vectors
>
> Thanks for addressing my other comments! I really like the new structure of having an `AlignmentSolution` interface with different alignment solution classes. I have some more comments but mostly fine tuning - it's already in a quite good shape and the comments really add a lot of benefit to understand the idea behind the code. We get there :-)

@chhagedorn Thanks for your already very detailed review!
I noticed that the whole section with the "constraints" was not very clear, it was too hand-wavy.
I refactored the solution quite a bit, and even fixed a bug with `init` (there should never be a constraint because of it). I state the solution more precise now, and the constraints follow more directly out of it. I think the solution is now even intuitively understandable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14785#issuecomment-1862614106