RFR: 8319793: C2 compilation fails with "Bad graph detected in build_loop_late" after JDK-8279888 [v7]

Fri Dec 15 14:38:46 UTC 2023

On Fri, 15 Dec 2023 14:29:05 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/loopopts.cpp line 360:
>> 
>>> 358:         // dependent nodes end up at the lowest/nearest dominating check in the graph. To ensure that these Loads/Casts
>>> 359:         // do not float above any of the dominating checks (even when the lowest dominating check is later replaced by
>>> 360:         // yet another dominating check), we need to pin them at the lowest dominating check.
>> 
>> Should we also add this updated comment to `ifnode.cpp:569` and `ifnode.cpp:1536`?
>
> Yes, right. Thanks! I updated the change.

Great, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16886#discussion_r1428044084