RFR: 8322490: CastNode constructors accepts control node as input [v2]
Joshua Cao
duke at openjdk.org
Thu Dec 21 05:23:11 UTC 2023
> It is a common pattern to have:
>
>
> Node* n = new CastNode(...);
> n->set_req(control_node);
>
>
> We can modify the constructor to set the control node. It makes the code a little tidier.
>
> Passes tier1 locally on my Linux machine
Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
Convert some CastIINode instantiations to use the constructor with ctrl
node
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17162/files
- new: https://git.openjdk.org/jdk/pull/17162/files/3c35568f..d9a40fd7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17162&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17162&range=00-01
Stats: 10 lines in 4 files changed: 0 ins; 5 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/17162.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17162/head:pull/17162
PR: https://git.openjdk.org/jdk/pull/17162
More information about the hotspot-compiler-dev
mailing list