RFR: 8322490: CastNode constructors accepts control node as input [v2]

[Christian Hagedorn]

On Thu, 21 Dec 2023 00:51:35 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> On a separate note and might be worth to do in this change as well, we have `ConstraintCastNode::make_cast_for_type()` and `ConstraintCastNode::make()`. The intent of the former is clear but the latter switches on the provided basic type. Maybe we can rename the latter to `make_cast_for_basic_type()` to better align it with `make_cast_for_type()`.
>
> Agree that `make_cast` probably is not needed. And your renaming suggestion makes sense.
> 
> Can we have this in a separate PR? I generally prefer to keep PRs as small of a unit as possible.

If you change the title of the PR into something like "cleanup CastNode construction" then I guess it's fine to do it all in once. But I leave it up to you to decide if you want to split it or not. Both is fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17162#discussion_r1433629316