RFR: 8301838: PPC: continuation yield intrinsic: exception check not needed if yield succeeded [v2]
Richard Reingruber
rrich at openjdk.org
Wed Feb 8 09:21:28 UTC 2023
On Wed, 8 Feb 2023 08:48:30 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Richard Reingruber has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - freeze(JavaThread* current, intptr_t* sp) returns int, so use 32bit compare
>> - Remove duplicated return sequence as Lutz suggested
>
> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 1998:
>
>> 1996: __ mtlr(R0);
>> 1997: __ blr();
>> 1998:
>
> This newly introduced code is an exact duplicate from below. I would prefer code reuse by treating the "L_pinned" part as "out-of-line". Instead of branching over forward_exception_entry, you could branch back to the return code. If you do so, the pop&return code below becomes obsolete.
Good idea. I've done that.
-------------
PR: https://git.openjdk.org/jdk/pull/12450
More information about the hotspot-compiler-dev
mailing list