RFR: 8302681: [IR Framework] Only allow cpuFeatures from a verified list

Tobias Hartmann thartmann at openjdk.org
Tue Feb 21 10:59:29 UTC 2023


On Mon, 20 Feb 2023 15:11:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> [TODO: some failures because of sse3. That may be another issue I need to fix.]

`sse3` is missing from your list, right?

Should we simply use the CPU features detected by the VM? For example:
https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/src/hotspot/cpu/x86/vm_version_x86.hpp#L322-L327
https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/src/hotspot/cpu/aarch64/vm_version_aarch64.hpp#L105-L110

This test does that too:
https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/test/lib-test/jdk/test/whitebox/CPUInfoTest.java#L53-L68

-------------

Changes requested by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12669


More information about the hotspot-compiler-dev mailing list