RFR: 8302681: [IR Framework] Only allow cpuFeatures from a verified list [v3]

[Emanuel Peter]

On Tue, 21 Feb 2023 10:57:02 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - add comment
>>  - modified test that used non-existent cpu feature
>
>> [TODO: some failures because of sse3. That may be another issue I need to fix.]
> 
> `sse3` is missing from your list, right?
> 
> Should we simply use the CPU features detected by the VM? For example:
> https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/src/hotspot/cpu/x86/vm_version_x86.hpp#L322-L327
> https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/src/hotspot/cpu/aarch64/vm_version_aarch64.hpp#L105-L110
> 
> This test does that too:
> https://github.com/openjdk/jdk/blob/f12710e938b36594623e9c82961d8aa0c0ef29c2/test/lib-test/jdk/test/whitebox/CPUInfoTest.java#L53-L68

@TobiHartmann I was actually missing a few cpu features. And a test needed to be corrected. I am running the tests again now.

I would like to keep the list small, and separate from other lists. It has to be clear that this list is verified, and if one adds something one has to be very sure that it is not a typo or non-existent.

If people need an additional feature, it can easily be verified and added.

-------------

PR: https://git.openjdk.org/jdk/pull/12669