[jdk20] RFR: 8299733: AArch64: "unexpected literal addressing mode" assertion failure with -XX:+PrintC1Statistics [v3]

Nick Gasson ngasson at openjdk.org
Tue Jan 10 09:45:06 UTC 2023


On Tue, 10 Jan 2023 05:19:08 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Nick Gasson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Enumerate all possible values of _mode
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 509:
> 
>> 507:   bool uses(Register reg) const {
>> 508:     switch (_mode) {
>> 509:     case literal:
> 
> Nit: You might want to leave a two-space indentation for each case. I think that's the coding style :-)

This file seems to have both styles, but the other switch statements in the `Assembler` class are indented like this (e.g. see `encode()` below).

-------------

PR: https://git.openjdk.org/jdk20/pull/87


More information about the hotspot-compiler-dev mailing list