[jdk20] RFR: 8299733: AArch64: "unexpected literal addressing mode" assertion failure with -XX:+PrintC1Statistics [v3]

[Fei Yang]

On Tue, 10 Jan 2023 09:42:05 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 509:
>> 
>>> 507:   bool uses(Register reg) const {
>>> 508:     switch (_mode) {
>>> 509:     case literal:
>> 
>> Nit: You might want to leave a two-space indentation for each case. I think that's the coding style :-)
>
> This file seems to have both styles, but the other switch statements in the `Assembler` class are indented like this (e.g. see `encode()` below).

Yeah, indeed. I even noticed this inconsistency of coding style in hotspot shared code. I guess it's OK to align with the surrounding code. Looks good to me. PS: I will prepare a similar enhancement for RISC-V on JDK master.

-------------

PR: https://git.openjdk.org/jdk20/pull/87