RFR: JDK-8300240: Replace NULL with nullptr in share/ci/

Fri Jan 20 10:28:28 UTC 2023

On Tue, 17 Jan 2023 11:07:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Do the conversion in the share/ci/ sub-directory and all of its files.

Hi @vnkozlov.

Regarding the confusion regarding `null` and `nullptr` in comments :). Yes, the idea is that we use `null` in comments as it reads better. In *some* situations I've chosen to keep `nullptr` in comments, this is specifically when there are code expressions (such as `nullptr == x`) in the comments. Sometimes I simply miss fixing them, because my script cannot deal with comments correctly and I need to alter them manually. This fact makes it a bit confusing to review, I agree.

This was discussed in a previous review, as you suspected.

Thank you for your comments!

-------------

PR: https://git.openjdk.org/jdk/pull/12029