RFR: JDK-8300240: Replace NULL with nullptr in share/ci/
Vladimir Kozlov
kvn at openjdk.org
Mon Jan 23 18:31:19 UTC 2023
On Tue, 17 Jan 2023 11:07:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Do the conversion in the share/ci/ sub-directory and all of its files.
Okay. After second look through I agree to use `null` in comments as it indeed sounds better.
I found several cases with `nullptr` in comments you missed. We should be consistent.
And one file which has copyright year update but no changes.
src/hotspot/share/ci/ciMethod.cpp line 786:
> 784: //
> 785: // Given a known receiver klass, find the target for the call.
> 786: // Return nullptr if the call has no target or the target is abstract.
Use `null`
src/hotspot/share/ci/ciMethod.cpp line 1035:
> 1033: // ciMethod::method_data_or_null
> 1034: // Returns a pointer to ciMethodData if MDO exists on the VM side,
> 1035: // nullptr otherwise.
Use `null`
src/hotspot/share/ci/ciMethodData.hpp line 522:
> 520:
> 521: // Get the data at an arbitrary bci, or null if there is none. If m
> 522: // is not nullptr look for a SpeculativeTrapData if any first.
Use `null`
-------------
Changes requested by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12029
More information about the hotspot-compiler-dev
mailing list