RFR: JDK-8300240: Replace NULL with nullptr in share/ci/

[Vladimir Kozlov]

On Mon, 23 Jan 2023 12:28:24 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>>> Regarding the confusion regarding `null` and `nullptr` in comments :). Yes, the idea is that we use `null` in comments as it reads better. In _some_ situations I've chosen to keep `nullptr` in comments, this is specifically when there are code
>> 
>> As owner of the code I prefer to match comments and code.
>> 
>>> This was discussed in a previous review, as you suspected.
>> 
>> Please, point me to that discussion.
>
>> > Regarding the confusion regarding `null` and `nullptr` in comments :). Yes, the idea is that we use `null` in comments as it reads better. In _some_ situations I've chosen to keep `nullptr` in comments, this is specifically when there are code
>> 
>> As owner of the code I prefer to match comments and code.
>> 
>> > This was discussed in a previous review, as you suspected.
>> 
>> Please, point me to that discussion.
> 
> Sure, the original PR where this was discussed is this one (with :  https://github.com/openjdk/jdk/pull/12015#issuecomment-1396711466
> 
> And here is Robbin's input: https://github.com/openjdk/jdk/pull/12094#issuecomment-1399978529

@jdksjolen  Thank you for links to previous discussions.  I think it all depends to local semantics. It is indeed sounds wrong when you say  "nullptr address" or "nullptr pointer". But in some cases where comment describe what code does it may still valid to use "nullptr". I will do one more round of review to make it clear where I want "null" and where I want "nullptr".

-------------

PR: https://git.openjdk.org/jdk/pull/12029