RFR: 8294066: IGV: Graph changes when deleting a graph in the same group with smaller index [v2]
Koichi Sakata
ksakata at openjdk.org
Mon Jan 30 06:58:19 UTC 2023
On Fri, 27 Jan 2023 10:33:32 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
>> Koichi Sakata has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Optimize imports and update copyright year
>
> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/actions/GraphRemoveCookie.java line 60:
>
>> 58: if (targetPosition < secondPosition) {
>> 59: secondPosition--;
>> 60: }
>
> Suggestion:
>
> }
> if (targetPosition == firstPosition || targetPosition == secondPosition) {
> t.close();
> }
Thank you for your suggestion. I've put this code before decrementing.
-------------
PR: https://git.openjdk.org/jdk/pull/12210
More information about the hotspot-compiler-dev
mailing list