RFR: 8294066: IGV: Graph changes when deleting a graph in the same group with smaller index [v2]

Tobias Holenstein tholenstein at openjdk.org
Mon Jan 30 08:48:21 UTC 2023


On Mon, 30 Jan 2023 06:55:06 GMT, Koichi Sakata <ksakata at openjdk.org> wrote:

>> src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/actions/GraphRemoveCookie.java line 60:
>> 
>>> 58:                     if (targetPosition < secondPosition) {
>>> 59:                         secondPosition--;
>>> 60:                     }
>> 
>> Suggestion:
>> 
>>                     }
>>                     if (targetPosition == firstPosition || targetPosition == secondPosition) {
>>                         t.close();
>>                     }
>
> Thank you for your suggestion. I've put this code before decrementing.

sure. thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12210


More information about the hotspot-compiler-dev mailing list