RFR: 8299683: [S390X] Problems with -XX:+VerifyStack

[Martin Doerr]

On Tue, 24 Jan 2023 06:40:37 GMT, sid8606 <duke at openjdk.org> wrote:

> Deoptimization and uncommon trap stubs require last Java PC to point to a PC which has an appropriate OopMap. Adjusting a offset for PC in last java frame.

src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 2693:

> 2691: 
> 2692:   // let the unpacker layout information in the skeletal frames just allocated.
> 2693:   offs = __ offset();

Shouldn't we use the offset from above instead of the current one? (PPC64 does that.) I think this line should get removed.

src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 2757:

> 2755:   // `Deoptimization::uncommon_trap' expects it and considers its
> 2756:   // sender frame as the deoptee frame.
> 2757:   int offs = __ offset();

`generate_uncommon_trap_blob()` has no oop_maps on s390. Most other platforms have them. I think this part of the change doesn't make sense without oop_maps.

-------------

PR: https://git.openjdk.org/jdk/pull/12161