RFR: 8299683: [S390X] Problems with -XX:+VerifyStack [v2]

sid8606 duke at openjdk.org
Tue Jan 31 08:44:59 UTC 2023


On Tue, 31 Jan 2023 04:53:01 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove offset changes from generate_uncommon_trap_blob stub
>>   
>>   Remove offset changes from generate_uncommon_trap_blob stub
>>   as it has no oop_maps on s390x.
>
> src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 2757:
> 
>> 2755:   // `Deoptimization::uncommon_trap' expects it and considers its
>> 2756:   // sender frame as the deoptee frame.
>> 2757:   int offs = __ offset();
> 
> `generate_uncommon_trap_blob()` has no oop_maps on s390. Most other platforms have them. I think this part of the change doesn't make sense without oop_maps.

Thanks for your comments, I have Addressed this comment in another commit.

-------------

PR: https://git.openjdk.org/jdk/pull/12161


More information about the hotspot-compiler-dev mailing list