RFR: 8299683: [S390X] Problems with -XX:+VerifyStack [v2]

[sid8606]

On Tue, 31 Jan 2023 04:22:47 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove offset changes from generate_uncommon_trap_blob stub
>>   
>>   Remove offset changes from generate_uncommon_trap_blob stub
>>   as it has no oop_maps on s390x.
>
> src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 2693:
> 
>> 2691: 
>> 2692:   // let the unpacker layout information in the skeletal frames just allocated.
>> 2693:   offs = __ offset();
> 
> Shouldn't we use the offset from above instead of the current one? (PPC64 does that.) I think this line should get removed.

I have tried that using same offset from above instead current one but it's not  pointing to correct PC for oop Maps.

-------------

PR: https://git.openjdk.org/jdk/pull/12161