RFR: 8308994: C2: Re-implement experimental post loop vectorization [v2]

Emanuel Peter epeter at openjdk.org
Mon Jul 3 07:59:12 UTC 2023


On Fri, 23 Jun 2023 11:24:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address part of comments from Emanuel
>
> src/hotspot/share/opto/vectornode.hpp line 1826:
> 
>> 1824: class LoopVectorMaskNode : public TypeNode {
>> 1825:  private:
>> 1826:   int _max_trips;
> 
> Add comment: what is this for exactly? Maybe consider adding more elaborate specification/description above the 3 node classes.
> 
> General code style: I think we are trying to get away from the `//--------------NodeName/FunctionName-------` tags, so no need to add them anymore.

That is already much better. Could you please also explain what the inputs mean and do?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14581#discussion_r1250426626


More information about the hotspot-compiler-dev mailing list