RFR: 8308994: C2: Re-implement experimental post loop vectorization [v2]

Pengfei Li pli at openjdk.org
Mon Jul 3 08:17:13 UTC 2023


On Mon, 3 Jul 2023 07:53:34 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.hpp line 1826:
>> 
>>> 1824: class LoopVectorMaskNode : public TypeNode {
>>> 1825:  private:
>>> 1826:   int _max_trips;
>> 
>> Add comment: what is this for exactly? Maybe consider adding more elaborate specification/description above the 3 node classes.
>> 
>> General code style: I think we are trying to get away from the `//--------------NodeName/FunctionName-------` tags, so no need to add them anymore.
>
> That is already much better. Could you please also explain what the inputs mean and do?

Ok, will do that later

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14581#discussion_r1250453061


More information about the hotspot-compiler-dev mailing list