RFR: 8310308: IR Framework: check for type and size of vector nodes [v18]

Emanuel Peter epeter at openjdk.org
Tue Jul 4 11:26:05 UTC 2023


On Tue, 4 Jul 2023 10:23:39 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more for Christian's reviews
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/constraint/raw/RawCountsConstraint.java line 62:
> 
>> 60:         switch (comparison.getComparator()) {
>> 61:             case "<" -> {
>> 62:                 TestFormat.checkNoReport(comparison.getGivenValue() > 1, "Node count comparison \"<" +
> 
> What if `comparison.getGivenValue()` is negative?

A rule like that would always fail.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1251894841


More information about the hotspot-compiler-dev mailing list