RFR: 8312547: Max/Min nodes Value implementation could be improved

[Jatin Bhateja]

On Tue, 25 Jul 2023 15:02:00 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> This patch removes the early return in `AddNode::Value` in case one of the inputs is a bottom, which may affect the value calculation of nodes such as `Min/MaxNode`.
> 
> Please kindly review, thanks very much.

src/hotspot/share/opto/addnode.cpp line 227:

> 225:   const Type *bot = bottom_type();
> 226:   if( (t1 == bot) || (t2 == bot) ||
> 227:       (t1 == Type::BOTTOM) || (t2 == Type::BOTTOM) )

We can  keep (t1 == Type::BOTTOM || t2 == Type::BOTTOM) condition intact.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15021#discussion_r1273884477