RFR: 8313141: Remove discarded volatile qualifier in assembler_aarch64.hpp

Andrew Haley aph at openjdk.org
Wed Jul 26 10:24:53 UTC 2023


On Wed, 26 Jul 2023 05:19:02 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> ISO C++ asm is always implicitly volatile, as per https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html, and all volatile qualifiers are always ignored if GNU asm was never used

src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 38:

> 36: #ifdef __GNUC__
> 37: 
> 38: // ISO C++ asm is always implicitly volatile

Is it? I think this comment needs a reference, or (maybe better) it should be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15031#discussion_r1274743317


More information about the hotspot-compiler-dev mailing list