RFR: 8313141: Remove discarded volatile qualifier in assembler_aarch64.hpp [v2]
Julian Waters
jwaters at openjdk.org
Thu Jul 27 04:15:06 UTC 2023
On Wed, 26 Jul 2023 10:21:28 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Reference in assembler_aarch64.hpp
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 38:
>
>> 36: #ifdef __GNUC__
>> 37:
>> 38: // ISO C++ asm is always implicitly volatile
>
> Is it? I think this comment needs a reference, or (maybe better) it should be removed.
I've added the reference, I don't think removing the comment explaining why the asm is declared this way is a good idea
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15031#discussion_r1275707302
More information about the hotspot-compiler-dev
mailing list