RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]

[Roland Westrelin]

On Tue, 25 Jul 2023 18:40:32 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> src/hotspot/share/opto/addnode.cpp line 227:
>> 
>>> 225:   const Type *bot = bottom_type();
>>> 226:   if( (t1 == bot) || (t2 == bot) ||
>>> 227:       (t1 == Type::BOTTOM) || (t2 == Type::BOTTOM) )
>> 
>> We can  keep (t1 == Type::BOTTOM || t2 == Type::BOTTOM) condition intact.
>
> I don't think `Type::BOTTOM` can appear here, there are other nodes (such as convert nodes) that do not check for `Type::BOTTOM`. Maybe someone could shed light on this, please?

I don't think `Type::BOTTOM` is possible here either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15021#discussion_r1274816879