RFR: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976 [v4]

[Cesar Soares Lucas]

On Fri, 28 Jul 2023 15:00:17 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Please review this PR to fix a potential null pointer access in using `_compile`.
>> Updated the code to unconditionally initialize `_compile` and added an assert (similar to C1's `PhaseTraceTime` constructor) for it to be non-null.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test config to use vm.compiler2.enabled
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 28:

> 26:  * @bug 8312596
> 27:  * @requires vm.debug == true & vm.compiler2.enabled
> 28:  * @summary Run with -Xcomp to test -XX:+TestPrintIdealNodeCount in debug builds.

Suggestion:

 * @summary Run with -Xcomp to test -XX:+PrintIdealNodeCount in debug builds.

test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 30:

> 28:  * @summary Run with -Xcomp to test -XX:+TestPrintIdealNodeCount in debug builds.
> 29:  *
> 30:  * @run main/othervm -Xcomp -XX:+PrintIdealNodeCount compiler.c2.TestPrintIdealNodeCount

I think just "-Xcomp" doesn't guarantee that C2 will be used, at least it won't as much as if you also add "-XX:-TieredCompilation".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277726690
PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277726406