RFR: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976 [v4]

[Ashutosh Mehra]

On Fri, 28 Jul 2023 15:54:54 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test config to use vm.compiler2.enabled
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 28:
> 
>> 26:  * @bug 8312596
>> 27:  * @requires vm.debug == true & vm.compiler2.enabled
>> 28:  * @summary Run with -Xcomp to test -XX:+TestPrintIdealNodeCount in debug builds.
> 
> Suggestion:
> 
>  * @summary Run with -Xcomp to test -XX:+PrintIdealNodeCount in debug builds.

copy-paste error. Thanks for pointing out.

> test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 30:
> 
>> 28:  * @summary Run with -Xcomp to test -XX:+TestPrintIdealNodeCount in debug builds.
>> 29:  *
>> 30:  * @run main/othervm -Xcomp -XX:+PrintIdealNodeCount compiler.c2.TestPrintIdealNodeCount
> 
> I think just "-Xcomp" doesn't guarantee that C2 will be used, at least it won't as much as if you also add "-XX:-TieredCompilation".

Okay, I will add `-XX:-TieredCompilation` as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277750852
PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277751378