RFR: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976 [v3]

Ashutosh Mehra duke at openjdk.org
Fri Jul 28 16:24:43 UTC 2023


On Fri, 28 Jul 2023 09:00:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright year and remove whitespace
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 27:
> 
>> 25:  * @test
>> 26:  * @bug 8312596
>> 27:  * @requires vm.debug == true & vm.flavor == "server"
> 
> This better be:
> 
> 
> * @requires vm.debug & vm.compiler2.enabled
> 
> 
> ...so that C1-only builds do not attempt to run this test and fail without `PrintIdealNodeCount` defined in `c2_globals.hpp`.

Makes sense. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277751307


More information about the hotspot-compiler-dev mailing list