RFR: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976 [v3]

[Aleksey Shipilev]

On Thu, 27 Jul 2023 13:38:09 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> Please review this PR to fix a potential null pointer access in using `_compile`.
>> Updated the code to unconditionally initialize `_compile` and added an assert (similar to C1's `PhaseTraceTime` constructor) for it to be non-null.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year and remove whitespace
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

Marked as reviewed by shade (Reviewer).

Ah, nit in test config.

test/hotspot/jtreg/compiler/c2/TestPrintIdealNodeCount.java line 27:

> 25:  * @test
> 26:  * @bug 8312596
> 27:  * @requires vm.debug == true & vm.flavor == "server"

This better be:


* @requires vm.debug & vm.compiler2.enabled


...so that C1-only builds do not attempt to run this test and fail without `PrintIdealNodeCount` defined in `c2_globals.hpp`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15002#pullrequestreview-1551670913
Changes requested by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15002#pullrequestreview-1551674317
PR Review Comment: https://git.openjdk.org/jdk/pull/15002#discussion_r1277298243