RFR: 8309129: AArch64: guarantee(T != T2S) failed: "incorrect arrangement" after JDK-8307795 [v3]

[Evgeny Astigeevich]

On Thu, 1 Jun 2023 06:33:56 GMT, Chang Peng <duke at openjdk.org> wrote:

>> This patch fixes the issue introduced by JDK-8307795. Since addv[1] cannot support "T2S" SIMD arrangement, we should use addp[2] in this case.
>> 
>> TEST passed on AArch64:
>> hotspot:compiler/vectorapi, jdk:jdk/incubator/vector, tier1-3
>> 
>> [1]: https://developer.arm.com/documentation/ddi0596/2020-12/SIMD-FP-Instructions/ADDV--Add-across-Vector-
>> [2]: https://developer.arm.com/documentation/ddi0596/2020-12/SIMD-FP-Instructions/ADDP--vector---Add-Pairwise--vector--
>
> Chang Peng has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update ProblemList and test case

test/hotspot/jtreg/compiler/vectorapi/TestVectorMaskTrueCount.java line 62:

> 60:     }
> 61: 
> 62:     static int maskAndTrueCount(boolean[] a, boolean[] b, int idx, int SPECIES_length) {

`SPECIES_length` confuses me. The first confusing thing is `SPECIES` in capital letters. The second is the name itself. From the code I see it has meaning of `count`. Maybe using `count` instead would be better?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14245#discussion_r1213188813