RFR: 8309129: AArch64: guarantee(T != T2S) failed: "incorrect arrangement" after JDK-8307795 [v3]

Chang Peng duke at openjdk.org
Mon Jun 5 06:55:11 UTC 2023


On Thu, 1 Jun 2023 13:50:19 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Chang Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update ProblemList and test case
>
> test/hotspot/jtreg/compiler/vectorapi/TestVectorMaskTrueCount.java line 62:
> 
>> 60:     }
>> 61: 
>> 62:     static int maskAndTrueCount(boolean[] a, boolean[] b, int idx, int SPECIES_length) {
> 
> `SPECIES_length` confuses me. The first confusing thing is `SPECIES` in capital letters. The second is the name itself. From the code I see it has meaning of `count`. Maybe using `count` instead would be better?

Thanks, I have modified the name of this parameter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14245#discussion_r1217603756


More information about the hotspot-compiler-dev mailing list