RFR: 8310192: RISC-V: Merge vector min & max instructs with similar match rules

Ludovic Henry luhenry at openjdk.org
Fri Jun 16 10:48:00 UTC 2023


On Fri, 16 Jun 2023 09:27:39 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, We merged vector min and max instructions with similar matching rules in this PR, and modified some comments of the copy_memory function in stubGenerator_riscv.cpp.
> We can use Float256VectorTests.java Double256VectorTests.java to emit vmax_fp/vmin_fp nodes and the compilation log is as follows:
> 
> 13e     B22: #	out( B50 B23 ) <- in( B21 )  Freq: 76.431
> 13e     loadV V2, [R17]	# vector (rvv)
> 146     vmax_fp V3, V1, V2
> 15e     bgeu  R9, R13, B50	#@cmpU_branch  P=0.000001 C=-1.000000
> 
> 
> 13e     B22: #	out( B50 B23 ) <- in( B21 )  Freq: 76.431
> 13e     loadV V2, [R17]	# vector (rvv)
> 146     vmin_fp V3, V1, V2
> 15e     bgeu  R9, R13, B50	#@cmpU_branch  P=0.000001 C=-1.000000
> 
> Please take a look and have some reviews. Thanks a lot.
> 
> ## Testing:
> - [x] Tier1 tests (release)
> - [x] Tier2 tests (release)
> - [x] Tier3 tests (release)
> - [x] test/jdk/jdk/incubator/vector (fastdebug)

Marked as reviewed by luhenry (Committer).

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 860:

> 858:   // of copy.  If is_aligned is false, we align the source address.
> 859:   //
> 860:   /*

Why the removal of that comment?

-------------

PR Review: https://git.openjdk.org/jdk/pull/14510#pullrequestreview-1483200976
PR Review Comment: https://git.openjdk.org/jdk/pull/14510#discussion_r1232088111


More information about the hotspot-compiler-dev mailing list